-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to check a container from another platform #829
Add the ability to check a container from another platform #829
Conversation
@@ -47,6 +48,9 @@ func checkContainerCmd() *cobra.Command { | |||
"URL paramater. This value may differ from the PID on the overview page. (env: PFLT_CERTIFICATION_PROJECT_ID)")) | |||
_ = viper.BindPFlag("certification_project_id", checkContainerCmd.Flags().Lookup("certification-project-id")) | |||
|
|||
checkContainerCmd.Flags().String("platform", rt.GOARCH, "Architecture of image to pull. Defaults to current platform.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice way to default!
If a multiarch manifest is supplied to check container, it would default to the platform preflight is running on. This --platform flag allows the user to choose with platform image to use, without having to resort to using SHA digests. Fixes redhat-openshift-ecosystem#807 Signed-off-by: Brad P. Crochet <brad@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If a multiarch manifest is supplied to check container, it would default to the platform preflight is running on. This --platform flag allows the user to choose with platform image to use, without having to resort to using SHA digests.
Fixes #807
Signed-off-by: Brad P. Crochet brad@redhat.com